[webkit-reviews] review granted: [Bug 211307] Text manipulation should observe the value attribute of some input elements : [Attachment 398246] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 211307: Text manipulation should observe the value attribute of some input
elements
https://bugs.webkit.org/show_bug.cgi?id=211307

Attachment 398246: Patch

https://bugs.webkit.org/attachment.cgi?id=398246&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 398246
  --> https://bugs.webkit.org/attachment.cgi?id=398246
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398246&action=review

> Source/WebCore/editing/TextManipulationController.cpp:233
> +    if (nameToCheck == valueAttr.get() && is<HTMLInputElement>(element))
> +	   return downcast<HTMLInputElement>(element).isTextButton();

I would write:

    if (nameToCheck == valueAttr)
	return is<HTMLInputElement>(element) &&
downcast<HTMLInputElement>(element).isTextButton();