[webkit-reviews] review granted: [Bug 209573] Quantifiers with min/max values exceeding 2 ** 32 - 1 should be valid : [Attachment 394623] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 209573: Quantifiers with min/max values exceeding 2 ** 32 - 1 should be
valid
https://bugs.webkit.org/show_bug.cgi?id=209573

Attachment 394623: Patch

https://bugs.webkit.org/attachment.cgi?id=394623&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 394623
  --> https://bugs.webkit.org/attachment.cgi?id=394623
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394623&action=review

> Source/JavaScriptCore/yarr/YarrPattern.cpp:956
> -	   ASSERT(minimumInputSize != UINT_MAX);
> +	   ASSERT(minimumInputSize <= UINT_MAX);

This assertion is meaningless. Of course an unsigned is <= unsigned maximum. So
this change is removing the assertion entirely. Which is fine, but just remove
it.