[webkit-reviews] review granted: [Bug 209607] Add SPI to specify whether file upload panels are uploading to an enterprise-managed destination : [Attachment 394626] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Quesada
<david_quesada at apple.com>'s request for review:
Bug 209607: Add SPI to specify whether file upload panels are uploading to an
enterprise-managed destination
https://bugs.webkit.org/show_bug.cgi?id=209607

Attachment 394626: Patch

https://bugs.webkit.org/attachment.cgi?id=394626&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 394626
  --> https://bugs.webkit.org/attachment.cgi?id=394626
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394626&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6609
> +    auto webView = _webView.get();

A little strange to make this local variable but only use it once.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6614
> +    if ([uiDelegate
respondsToSelector:@selector(_webView:fileUploadPanelContentIsManagedWithInitia
tingFrame:)])
> +	   return [uiDelegate _webView:webView.get()
fileUploadPanelContentIsManagedWithInitiatingFrame:wrapper(API::FrameInfo::crea
te(WTFMove(_frameInfoForFileUploadPanel), _page.get()))];
> +
> +    return NO;

I would have used && here.