[webkit-reviews] review granted: [Bug 209372] Adopt -[UIWindowScene interfaceOrientation] when determining device orientation : [Attachment 394183] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 209372: Adopt -[UIWindowScene interfaceOrientation] when determining device
orientation
https://bugs.webkit.org/show_bug.cgi?id=209372

Attachment 394183: Patch

https://bugs.webkit.org/attachment.cgi?id=394183&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 394183
  --> https://bugs.webkit.org/attachment.cgi?id=394183
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394183&action=review

How can we make an automated test for this?

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:229
> +    auto *application = UIApplication.sharedApplication;

Just auto would be better. Let’s dodge the * placement issue.

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:234
> +    else if (auto *windowScene = self.window.windowScene)

Ditto.