[webkit-reviews] review granted: [Bug 209380] Support inserting text or dictation alternative by simulating keyboard input : [Attachment 394197] Patch and unit tests

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 209380: Support inserting text or dictation alternative by simulating
keyboard input
https://bugs.webkit.org/show_bug.cgi?id=209380

Attachment 394197: Patch and unit tests

https://bugs.webkit.org/attachment.cgi?id=394197&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 394197
  --> https://bugs.webkit.org/attachment.cgi?id=394197
Patch and unit tests

View in context: https://bugs.webkit.org/attachment.cgi?id=394197&action=review

> Source/WebKit/Shared/Cocoa/InsertTextOptions.h:37
> +    bool simulateKeyboardInput { false };

As you know, Cocoa programming style suggests naming boolean properties in a
way that disambiguates from a function that would take action. So
shouldSimulateKeyboardInput because simulateKeyboardInput reads like a command
that would do something immediately rather than a setting for what should be
done.

We should consider that style for the booleans in this structure.