[webkit-reviews] review canceled: [Bug 206680] [ macOS ] fast/frames/sandboxed-iframe-navigation-allowed.html is flaky failing : [Attachment 393422] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has canceled Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 206680: [ macOS ] fast/frames/sandboxed-iframe-navigation-allowed.html is
flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206680

Attachment 393422: Patch

https://bugs.webkit.org/attachment.cgi?id=393422&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 393422
  --> https://bugs.webkit.org/attachment.cgi?id=393422
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393422&action=review

>> LayoutTests/fast/frames/resources/sandboxed-iframe-navigation-child.html:-6
>> -	self.navigated.location.assign("javascript:
top.childFrameWasNavigated();");
> 
> Isn't the test all about executing this code in a subframe?

Looking at the test description, I think you are right that this is part of the
thing that was tested (should be able to navigate subframe). I will address the
flakiness some other way then.