[webkit-reviews] review granted: [Bug 209021] Crash in TextManipulationController::replace : [Attachment 393421] Fixes the bug

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 209021: Crash in TextManipulationController::replace
https://bugs.webkit.org/show_bug.cgi?id=209021

Attachment 393421: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=393421&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 393421
  --> https://bugs.webkit.org/attachment.cgi?id=393421
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=393421&action=review

> Source/WebCore/editing/TextManipulationController.cpp:580
> +    Position insertionPoint =
positionBeforeNode(firstContentNode.get()).parentAnchoredEquivalent();

Is it possible `firstContentNode` is null here? That would lead to a debug
assertion in positionBeforeNode.


(Seems like the answer is no because we’d already bail in the early return
above…?)