[webkit-reviews] review granted: [Bug 208481] Align garbage collection for XMLHttpRequest objects with the specification : [Attachment 392809] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 208481: Align garbage collection for XMLHttpRequest objects with the
specification
https://bugs.webkit.org/show_bug.cgi?id=208481

Attachment 392809: Patch

https://bugs.webkit.org/attachment.cgi?id=392809&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 392809
  --> https://bugs.webkit.org/attachment.cgi?id=392809
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392809&action=review

> Source/WebCore/ChangeLog:11
> +	   e now override ActiveDOMObject::hasPendingActivity() to match
exactly the text

Nit: e -> We?

> Source/WebCore/xml/XMLHttpRequest.cpp:1167
> +	   || hasEventListeners(eventNames().loadEvent)
> +	   || hasEventListeners(eventNames().timeoutEvent)

Can we order these events in alphabetical/lexicological order?