[webkit-reviews] review granted: [Bug 208816] Remove sync IPC when creating a remote capture source : [Attachment 393043] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 208816: Remove sync IPC when creating a remote capture source
https://bugs.webkit.org/show_bug.cgi?id=208816

Attachment 393043: Patch

https://bugs.webkit.org/attachment.cgi?id=393043&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 393043
  --> https://bugs.webkit.org/attachment.cgi?id=393043
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393043&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:98
> +    CompletionHandler<void(String&&)> waitForAudioSource = [audioSource,
videoSource = WTFMove(videoSource), logger = WTFMove(logger), completionHandler
= WTFMove(completionHandler)](auto&& errorMessage) mutable {

Shouldn't this be called 'waitForVideoSource'?

Why do you WTFMove() videoSource but not audioSource?