[webkit-reviews] review granted: [Bug 208655] Remove the experimental flag for Pointer Events : [Attachment 392706] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 208655: Remove the experimental flag for Pointer Events
https://bugs.webkit.org/show_bug.cgi?id=208655

Attachment 392706: Patch

https://bugs.webkit.org/attachment.cgi?id=392706&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 392706
  --> https://bugs.webkit.org/attachment.cgi?id=392706
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392706&action=review

I guess this is OK. If not all platforms have this feature enabled, I could
imagine some might still want an experimental runtime flag for it. Typically
I’d expect us to remove the runtime flag at the same time as we remove the
compile-time flag.

What platforms have POINTER_EVENTS off?

> Source/WebCore/dom/NavigatorMaxTouchPoints.idl:31
> +    Conditional=POINTER_EVENTS

I think our tradition is to sort these alphabetically instead of having them in
an arbitrary order and put commas on every line so it’s easy to add and remove
lines without a special case for the last line.

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:3243
>  - (BOOL)syntheticEditingCommandsEnabled
>  {
> -    return [self _boolValueForKey:WebKitPointerEventsEnabledPreferenceKey];
> +    return [self
_boolValueForKey:WebKitSyntheticEditingCommandsEnabledPreferenceKey];
>  }

Oops!

I guess no one was using this?

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:3248
>  - (void)setSyntheticEditingCommandsEnabled:(BOOL)flag
>  {
> -    [self _setBoolValue:flag
forKey:WebKitPointerEventsEnabledPreferenceKey];
> +    [self _setBoolValue:flag
forKey:WebKitSyntheticEditingCommandsEnabledPreferenceKey];
>  }

Oops!

> Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:-590
> -- (void)setPointerEventsEnabled:(BOOL)flag;
> -- (BOOL)pointerEventsEnabled;

This is a Private.h header, so SPI. How do we know no one is calling it? In the
past we sometimes leave these methods around and just empty their bodies out.