[webkit-reviews] review granted: [Bug 208642] REGRESSION: (r257905) [ Mac wk2 Debug ] ASSERTION FAILED: !m_isolatedWorld->isNormal() || m_wrapper || !m_jsFunction : [Attachment 392911] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 208642: REGRESSION: (r257905) [ Mac wk2 Debug ] ASSERTION FAILED:
!m_isolatedWorld->isNormal() || m_wrapper || !m_jsFunction
https://bugs.webkit.org/show_bug.cgi?id=208642

Attachment 392911: Patch

https://bugs.webkit.org/attachment.cgi?id=392911&action=review




--- Comment #48 from Darin Adler <darin at apple.com> ---
Comment on attachment 392911
  --> https://bugs.webkit.org/attachment.cgi?id=392911
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392911&action=review

> Source/WebCore/bindings/js/JSEventListener.cpp:57
> +    if (!wrapper) {
>	   ASSERT(!function);
> +	   return;
> +    }

Inconsistent to use early return for (!wrapper), but a normal if statement for
(function). I suggest we write this instead:

    if (function) {
	ASSERT(wrapper);
	...