[webkit-reviews] review granted: [Bug 208727] [GPUP] Move AVSystemController code into the GPU process : [Attachment 392755] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 208727: [GPUP] Move AVSystemController code into the GPU process
https://bugs.webkit.org/show_bug.cgi?id=208727

Attachment 392755: Patch

https://bugs.webkit.org/attachment.cgi?id=392755&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 392755
  --> https://bugs.webkit.org/attachment.cgi?id=392755
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392755&action=review

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:72
> +#if HAVE(MEDIA_PLAYER) && !PLATFORM(WATCHOS)

HAVE_MEDIA_PLAYER is always defined for PLATFORM(COCOA)

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:88
> +#if HAVE(MEDIA_PLAYER) && !PLATFORM(WATCHOS)

Ditto.

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:183
> +    m_objcObserver = nil;

Nit: this isn't necessary since it is a RetainPtr

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:361
> +#if HAVE(MEDIA_PLAYER) && !PLATFORM(WATCHOS)

HAVE_MEDIA_PLAYER is always defined for PLATFORM(COCOA)

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:387
> +#if HAVE(MEDIA_PLAYER) && !PLATFORM(WATCHOS)

Ditto