[webkit-reviews] review granted: [Bug 208725] JSON.stringify should call replacer on deleted properties : [Attachment 392766] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 208725: JSON.stringify should call replacer on deleted properties
https://bugs.webkit.org/show_bug.cgi?id=208725

Attachment 392766: Patch

https://bugs.webkit.org/attachment.cgi?id=392766&action=review




--- Comment #3 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 392766
  --> https://bugs.webkit.org/attachment.cgi?id=392766
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392766&action=review

This seems reasonable, particularly given the discussion about `get` in the
previous patch.

I'm not used to practices surrounding microbenchmarks, but they seem reasonable
to me based on existing ones.

> Source/JavaScriptCore/ChangeLog:15
> +	   [1]: https://tc39.es/ecma262/#sec-serializejsonobject (steps 6, 8.a)

Is this sufficient/correct as a spec link? It seems like all three cases are
removing early outs, but this just covers the object case (though I guess
that's the one case with the visible conformance failure).