[webkit-reviews] review granted: [Bug 208707] Add support for NowPlaying commands in GPUProcess : [Attachment 392712] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 208707: Add support for NowPlaying commands in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=208707

Attachment 392712: Patch

https://bugs.webkit.org/attachment.cgi?id=392712&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 392712
  --> https://bugs.webkit.org/attachment.cgi?id=392712
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392712&action=review

> Source/WebKit/ChangeLog:9
> +	   Each GPUConnectionToWebProcess is nwo a NowPlayingManager client.

s/nwo/now/

> Source/WebCore/platform/NowPlayingManager.cpp:59
> +    if (m_client.get() != &client)
> +	   return;

Should we ASSERT this?

> Source/WebCore/platform/NowPlayingManager.h:53
> +    void clearNowPlayingInfo(Client&);
> +    void setNowPlayingInfo(Client&, NowPlayingInfo&&);

Nit: It seems like this is really about setting/clearing the client, so I
wonder if "NowPlayingClient" would be better than "NowPlayingInfo"?