[webkit-reviews] review granted: [Bug 208692] TextManipulationController should preserve images : [Attachment 392695] Added more change log descriptions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 6 08:41:47 PST 2020


Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 208692: TextManipulationController should preserve images
https://bugs.webkit.org/show_bug.cgi?id=208692

Attachment 392695: Added more change log descriptions

https://bugs.webkit.org/attachment.cgi?id=392695&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 392695
  --> https://bugs.webkit.org/attachment.cgi?id=392695
Added more change log descriptions

View in context: https://bugs.webkit.org/attachment.cgi?id=392695&action=review

> Source/WebCore/ChangeLog:15
> +	   including ones that do not generate text in Textiterator. This also
allows more code sharing between

Nit - Textiterator => TextIterator

> Source/WebCore/ChangeLog:18
> +	   For now, we special case nodes with RenderReplace like img element
and the root SVG element.

Nit - RenderReplace => RenderReplaced


More information about the webkit-reviews mailing list