[webkit-reviews] review granted: [Bug 213502] [GTK][WPE] Change the cookies accept policy when ITP is enabled : [Attachment 403051] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 213502: [GTK][WPE] Change the cookies accept policy when ITP is enabled
https://bugs.webkit.org/show_bug.cgi?id=213502

Attachment 403051: Patch

https://bugs.webkit.org/attachment.cgi?id=403051&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 403051
  --> https://bugs.webkit.org/attachment.cgi?id=403051
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403051&action=review

OK, I'm pretty sure this is a sensible approach, but I'd still like to hear
from Apple what their recommendation is. Seems like their API has exactly the
same problem.

> Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp:207
> + * Note that the returned policy will always be
%WEBKIT_COOKIE_POLICY_ACCEPT_ALWAYS while

while -> if