[webkit-reviews] review granted: [Bug 213728] Remove ENABLE_STREAMS_API compile flag : [Attachment 403056] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Tetsuharu Ohzeki
<tetsuharu.ohzeki at gmail.com>'s request for review:
Bug 213728: Remove ENABLE_STREAMS_API compile flag
https://bugs.webkit.org/show_bug.cgi?id=213728

Attachment 403056: Patch

https://bugs.webkit.org/attachment.cgi?id=403056&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 403056
  --> https://bugs.webkit.org/attachment.cgi?id=403056
Patch

r=me once bots are happy.
Please revert/update some of the changes made to the generator tests.

View in context: https://bugs.webkit.org/attachment.cgi?id=403056&action=review

> Source/JavaScriptCore/ChangeLog:8
> +	   I regeneted expectations by
Tools/Scripts/run-builtins-generator-tests

regenerated

>
Source/JavaScriptCore/Scripts/tests/builtins/WebCore-ArbitraryConditionalGuard-
Separate.js:-26
> -// @conditional=ENABLE(STREAMS_API) || USE(CF)

I do not think we want to remove those since they are checking that the
generator works fine.
You might want to change the name maybe to make it clear.

>
Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-DuplicateKeyValue
Annotation-Separate.js-result:1
> +### Begin File: DuplicateKeyValueAnnotationBuiltins.h

I guess this new file has nothing to do with streams API but we somehow forgot
to regenerate expectations.
It seems our bots should have caught this missing file.