[webkit-reviews] review granted: [Bug 213689] Fix thread-safety issue in webProcessPoolHighDynamicRangeDidChangeCallback() : [Attachment 402976] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 213689: Fix thread-safety issue in
webProcessPoolHighDynamicRangeDidChangeCallback()
https://bugs.webkit.org/show_bug.cgi?id=213689

Attachment 402976: Patch

https://bugs.webkit.org/attachment.cgi?id=402976&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 402976
  --> https://bugs.webkit.org/attachment.cgi?id=402976
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402976&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:906
> +    dispatch_async(dispatch_get_main_queue(), ^{

Just curious: why did you select dispatch to the main queue over other
techniques for running on the main thread?

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:907
> +	   auto screenProperties = WebCore::collectScreenProperties();

In a small function/tight context like this, I like just using one word names,
like "properties" here.

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:908
> +	   for (auto& processPool : WebProcessPool::allProcessPools())

And "pool" here.