[webkit-reviews] review requested: [Bug 213345] Unify Bitmap math loops in MarkedBlock::Handle::specializedSweep(). : [Attachment 402225] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 18 12:47:04 PDT 2020


Saam Barati <sbarati at apple.com> has asked  for review:
Bug 213345: Unify Bitmap math loops in MarkedBlock::Handle::specializedSweep().
https://bugs.webkit.org/show_bug.cgi?id=213345

Attachment 402225: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=402225&action=review




--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 402225
  --> https://bugs.webkit.org/attachment.cgi?id=402225
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=402225&action=review

> Source/JavaScriptCore/heap/MarkedBlockInlines.h:369
> +    // At this point, a set bit in freeAtoms represents live cells.

this is no longer true, right? Opposite


More information about the webkit-reviews mailing list