[webkit-reviews] review granted: [Bug 213345] Unify Bitmap math loops in MarkedBlock::Handle::specializedSweep(). : [Attachment 402225] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 18 12:41:15 PDT 2020


Robin Morisset <rmorisset at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 213345: Unify Bitmap math loops in MarkedBlock::Handle::specializedSweep().
https://bugs.webkit.org/show_bug.cgi?id=213345

Attachment 402225: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=402225&action=review




--- Comment #4 from Robin Morisset <rmorisset at apple.com> ---
Comment on attachment 402225
  --> https://bugs.webkit.org/attachment.cgi?id=402225
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=402225&action=review

r=me

> Source/JavaScriptCore/heap/MarkedBlockInlines.h:345
> +    if (emptyMode == NotEmpty) {

This section is *much* more readable than before, thanks!


More information about the webkit-reviews mailing list