[webkit-reviews] review denied: [Bug 214990] Added AudioBuffer Constructor : [Attachment 405704] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 31 13:36:52 PDT 2020


Chris Dumez <cdumez at apple.com> has denied Clark Wang <clark_wang at apple.com>'s
request for review:
Bug 214990: Added AudioBuffer Constructor
https://bugs.webkit.org/show_bug.cgi?id=214990

Attachment 405704: Patch

https://bugs.webkit.org/attachment.cgi?id=405704&action=review




--- Comment #16 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 405704
  --> https://bugs.webkit.org/attachment.cgi?id=405704
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405704&action=review

> Source/WebCore/Modules/webaudio/AudioBufferOptions.h:34
> +    unsigned length;

Needs an initializer

> Source/WebCore/Modules/webaudio/AudioBufferOptions.h:35
> +    float sampleRate;

Needs an initializer


More information about the webkit-reviews mailing list