[webkit-reviews] review granted: [Bug 215022] [Mac] YouTube does not offer HDR variants to devices which support HDR : [Attachment 405725] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 215022: [Mac] YouTube does not offer HDR variants to devices which support
HDR
https://bugs.webkit.org/show_bug.cgi?id=215022

Attachment 405725: Patch

https://bugs.webkit.org/attachment.cgi?id=405725&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 405725
  --> https://bugs.webkit.org/attachment.cgi?id=405725
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405725&action=review

> Source/WebCore/Modules/mediasource/MediaSource.cpp:724
> +    if (scriptExecutionContext() && scriptExecutionContext()->isDocument()
&&
downcast<Document>(scriptExecutionContext())->quirks().needsVP9FullRangeFlagQui
rk())

Any you use `context`?

> Source/WebCore/Modules/mediasource/MediaSource.cpp:1079
> +    if (scriptExecutionContext() && scriptExecutionContext()->isDocument()
&&
downcast<Document>(scriptExecutionContext())->quirks().needsVP9FullRangeFlagQui
rk())

A local context variable would be better than calling
`scriptExecutionContext()` multiple times.