[webkit-reviews] review requested: [Bug 204457] Math.max() can yield the wrong result for max(0, -0). : [Attachment 404452] Math.{max, min} fixes, v4

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 204457: Math.max() can yield the wrong result for max(0, -0).
https://bugs.webkit.org/show_bug.cgi?id=204457

Attachment 404452: Math.{max,min} fixes, v4

https://bugs.webkit.org/attachment.cgi?id=404452&action=review




--- Comment #21 from Xan Lopez <xan.lopez at gmail.com> ---
Created attachment 404452

  --> https://bugs.webkit.org/attachment.cgi?id=404452&action=review

Math.{max,min} fixes, v4

This should address all your comments. I'm comparing the testmasm results in
uint64_t form, though (instead of casting back to double), because otherwise a
lot of the results are just NaN and we get bogus (I think) errors. I think this
should be fine but a sanity check is welcome.