[webkit-reviews] review denied: [Bug 214381] Added Fixes for AudioScheduledSourceNode : [Attachment 404450] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Clark Wang <clark_wang at apple.com>'s
request for review:
Bug 214381: Added Fixes for AudioScheduledSourceNode
https://bugs.webkit.org/show_bug.cgi?id=214381

Attachment 404450: Patch

https://bugs.webkit.org/attachment.cgi?id=404450&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 404450
  --> https://bugs.webkit.org/attachment.cgi?id=404450
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404450&action=review

> Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl:29
>      ActiveDOMObject,

You should be able to drop this now.

> Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl:30
> +] interface AudioBufferSourceNode : AudioScheduledSourceNode {

Well, then you'd want to drop start() / stop() / onended from this interface..

> Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:139
> +ExceptionOr<void> AudioScheduledSourceNode::startLater(Optional<double>
optionalWhen)

That's wrong. There is already a default value of 0 in the IDL so the generated
bindings will always give you a double.

> Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:159
> +ExceptionOr<void> AudioScheduledSourceNode::stopLater(Optional<double>
optionalWhen)

Ditto.

> Source/WebCore/Modules/webaudio/OscillatorNode.idl:37
>      ActiveDOMObject,

You should be able to drop this now.

> Source/WebCore/Modules/webaudio/OscillatorNode.idl:38
> +] interface OscillatorNode : AudioScheduledSourceNode {

Well, then you'd want to drop start() / stop() / onended from this interface..