[webkit-reviews] review granted: [Bug 206806] Support 'allow="fullscreen"' feature policy : [Attachment 388799] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 206806: Support 'allow="fullscreen"' feature policy
https://bugs.webkit.org/show_bug.cgi?id=206806

Attachment 388799: Patch

https://bugs.webkit.org/attachment.cgi?id=388799&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 388799
  --> https://bugs.webkit.org/attachment.cgi?id=388799
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388799&action=review

> Source/WebCore/dom/FullscreenManager.cpp:64
> +    }

This code is very similar with UserMediaController isAllowedToUse.
Maybe we should add a routine for crawling up the tree.

> Source/WebCore/html/FeaturePolicy.cpp:148
> +	   if (iframe.hasAttribute(allowfullscreenAttr) ||
iframe.hasAttribute(webkitallowfullscreenAttr)) {

GTK does not like it, unified build issue maybe, HTMLNames.h missing probably.

> LayoutTests/http/tests/fullscreen/fullscreen-feature-policy.html:55
> +    <iframe allow="fullscreen *" data-enabled="true"
src="http://localhost:8000/resources/pointer-lock/inner-iframe.html"></iframe>

Maybe add a test like allow="fullscreen http://localhost..."?

Also, there are probably WPT tests that are testing this but there is no
rebasing.
Are there some WPT test we should import?