[webkit-reviews] review denied: [Bug 180913] [GTK] Fix compilation failures for a Release build with assertions turned on : [Attachment 329602] fix NDEBUG conditionals for a Release build with assertions turned on

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied  review:
Bug 180913: [GTK] Fix compilation failures for a Release build with assertions
turned on
https://bugs.webkit.org/show_bug.cgi?id=180913

Attachment 329602: fix NDEBUG conditionals for a Release build with assertions
turned on

https://bugs.webkit.org/attachment.cgi?id=329602&action=review




--- Comment #7 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 329602
  --> https://bugs.webkit.org/attachment.cgi?id=329602
fix NDEBUG conditionals for a Release build with assertions turned on

This is exactly the wrong thing to do.	The right thing to do is to find those
fields which are needed for the ASSERT but are guarded by #if !NDEBUGand change
them to be guarded by #if ASSERT_ENABLED because they are relevant to the
assertion, and not a debug build per se.