[webkit-reviews] review granted: [Bug 206798] Tighten up some of the drag state machine logic : [Attachment 388774] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 206798: Tighten up some of the drag state machine logic
https://bugs.webkit.org/show_bug.cgi?id=206798

Attachment 388774: Patch

https://bugs.webkit.org/attachment.cgi?id=388774&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 388774
  --> https://bugs.webkit.org/attachment.cgi?id=388774
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388774&action=review

Thanks for the patch! r=me with the build fix.

> Source/WebCore/page/EventHandler.cpp:3651
> +    if (dragState().source && dragState().dataTransfer() &&
dragState().shouldDispatchEvents) {

`dragState().dataTransfer()` => `dragState().dataTransfer`

I wonder if it might be nice to pull the (source && dataTransfer &&
shouldDispatchEvents) check into either a helper function or method on
DragState, since we have it in two places here.