[webkit-reviews] review granted: [Bug 206615] REGRESSION: [ Mac WK2 ] animations/suspend-resume-animation-events.html is a flaky failure : [Attachment 388773] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 25 11:54:59 PST 2020


Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 206615: REGRESSION: [ Mac WK2 ]
animations/suspend-resume-animation-events.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206615

Attachment 388773: Patch

https://bugs.webkit.org/attachment.cgi?id=388773&action=review




--- Comment #6 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 388773
  --> https://bugs.webkit.org/attachment.cgi?id=388773
Patch

The change looks harmless with regards to what this tests check for, and likely
beneficial for test reliability. However, I do not understand what is wrong
with the test as is. 

The animation starts before any setTimeouts, and is shorter. Wouldn’t it be an
actual WebKit bug if there is raciness?


More information about the webkit-reviews mailing list