[webkit-reviews] review granted: [Bug 206216] PointerEvent has 0 as pressure when the input device is not pressure-sensitive : [Attachment 388210] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Akihiko Odaki <nekomanma at pixiv.com>'s
request for review:
Bug 206216: PointerEvent has 0 as pressure when the input device is not
pressure-sensitive
https://bugs.webkit.org/show_bug.cgi?id=206216

Attachment 388210: Patch

https://bugs.webkit.org/attachment.cgi?id=388210&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 388210
  --> https://bugs.webkit.org/attachment.cgi?id=388210
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388210&action=review

> Source/WebCore/dom/PointerEvent.cpp:115
> +    , m_pressure(mouseEvent.buttons() ? 0.5 : 0)

I am not 100% sure this is right. The specification calls for all pointerup
events having pressure of 0. Are we guaranteed that buttons() will be 0 for
*all* pointerup events? The test case covers only a simple case of a mouse with
a single button.

> LayoutTests/ChangeLog:11
> +	   * pointerevents/mouse/pointer-button-and-buttons-expected.txt:
Removed.
> +	   * pointerevents/mouse/pointer-button-and-buttons.html: Removed.
> +	   *
pointerevents/mouse/pointer-button-buttons-and-pressure-expected.txt: Added.
> +	   * pointerevents/mouse/pointer-button-buttons-and-pressure.html:
Added.

Why are we renaming this test case?