[webkit-reviews] review granted: [Bug 203084] Cleanup dead initializations in JSC code : [Attachment 388231] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Paulo Matos <pmatos at igalia.com>'s
request for review:
Bug 203084: Cleanup dead initializations in JSC code
https://bugs.webkit.org/show_bug.cgi?id=203084

Attachment 388231: Patch

https://bugs.webkit.org/attachment.cgi?id=388231&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 388231
  --> https://bugs.webkit.org/attachment.cgi?id=388231
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388231&action=review

> Source/JavaScriptCore/API/tests/TypedArrayCTest.cpp:194
> -	   typedArray = JSObjectMakeTypedArrayWithArrayBufferAndOffset(context,
type, data, 1, length-1, &exception);
> +	   JSObjectMakeTypedArrayWithArrayBufferAndOffset(context, type, data,
1, length-1, &exception);

This change does not yet seem quite right to me. Why change this call to
JSObjectMakeTypedArrayWithArrayBufferAndOffset and not the next call just below
after the if statement, which also sets a value of typedArray that is never
looked at?