[webkit-reviews] review denied: [Bug 205913] [GTK] Editing: Allow line breaks in lists : [Attachment 387092] proposed patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Milan Crha
<mcrha at redhat.com>'s request for review:
Bug 205913: [GTK] Editing: Allow line breaks in lists
https://bugs.webkit.org/show_bug.cgi?id=205913

Attachment 387092: proposed patch

https://bugs.webkit.org/attachment.cgi?id=387092&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 387092
  --> https://bugs.webkit.org/attachment.cgi?id=387092
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387092&action=review

r- because the changelog is not correct, cq won't allow this in any case.

> Source/WebKit/ChangeLog:9
> +	Treat Shift+Enter as "InsertLineBreak", instead of "InsertParagraph".

I guess you mean instead of "InsertNewLine"

> Source/WebKit/ChangeLog:10
> +

This ChangeLog is not correctly formatted... we need to figure out why the
script doesn't work for you.

> Source/WebKit/UIProcess/gtk/KeyBindingTranslator.cpp:217
>      // Special-case enter keys for we want them to work regardless of
modifier.

This comment is no longer accurate. Could we just handle enter keys as all
other custom key bindings and add them to the table above and just reove this
special case?