[webkit-reviews] review requested: [Bug 205913] [GTK] Editing: Allow line breaks in lists : [Attachment 387092] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 8 03:22:41 PST 2020


Milan Crha <mcrha at redhat.com> has asked  for review:
Bug 205913: [GTK] Editing: Allow line breaks in lists
https://bugs.webkit.org/show_bug.cgi?id=205913

Attachment 387092: proposed patch

https://bugs.webkit.org/attachment.cgi?id=387092&action=review




--- Comment #1 from Milan Crha <mcrha at redhat.com> ---
Created attachment 387092

  --> https://bugs.webkit.org/attachment.cgi?id=387092&action=review

proposed patch

Here is a proposed patch. It's not only for lists, but I think it's fine.

Notes: I wanted to use "prepare-ChangeLog" script, but it failed with the below
error. It doesn't know I changed anything, even the 'git status' says:

> On branch webkit-2.26
> Changes not staged for commit:
>   (use "git add <file>..." to update what will be committed)
>   (use "git checkout -- <file>..." to discard changes in working directory)
>
>	modified:   Source/WebKit/UIProcess/gtk/KeyBindingTranslator.cpp
>
> no changes added to commit (use "git add" and/or "git commit -a")

Thus there's something fishy about it, or the script works differently since
the last time I used it (which is years ago). As this failed, I didn't go
through step 7 of the https://webkit.org/contributing-code/ ; I just made the
patch with `git diff`.

-----------------------------------------------------------------------------

The error output promised at the top:

$ Tools/Scripts/prepare-ChangeLog --style -b
https://bugs.webkit.org/show_bug.cgi?id=205913
  Running check-webkit-style.
  Traceback (most recent call last):
  File
"/data/develop/test-wk2/_other/webkit.master/Tools/Scripts/check-webkit-style",
line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File
"/data/develop/test-wk2/_other/webkit.master/Tools/Scripts/webkitpy/style/main.
py", line 153, in main
    patch = host.scm().create_patch(options.git_commit,
changed_files=changed_files, git_index=options.git_index)
  File
"/data/develop/test-wk2/_other/webkit.master/Tools/Scripts/webkitpy/common/chec
kout/scm/git.py", line 354, in create_patch
    command += [self.merge_base(git_commit)]
  File
"/data/develop/test-wk2/_other/webkit.master/Tools/Scripts/webkitpy/common/chec
kout/scm/git.py", line 215, in merge_base
    return self.remote_merge_base()
  File
"/data/develop/test-wk2/_other/webkit.master/Tools/Scripts/webkitpy/common/chec
kout/scm/git.py", line 528, in remote_merge_base
    return self._run_git(['merge-base', self.remote_branch_ref(),
'HEAD']).strip()
  File
"/data/develop/test-wk2/_other/webkit.master/Tools/Scripts/webkitpy/common/chec
kout/scm/git.py", line 106, in _run_git
    return self.run(full_command_args, **full_kwargs)
  File
"/data/develop/test-wk2/_other/webkit.master/Tools/Scripts/webkitpy/common/chec
kout/scm/scm.py", line 78, in run
    decode_output=decode_output)
  File
"/data/develop/test-wk2/_other/webkit.master/Tools/Scripts/webkitpy/common/syst
em/executive.py", line 412, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File
"/data/develop/test-wk2/_other/webkit.master/Tools/Scripts/webkitpy/common/syst
em/abstractexecutive.py", line 97, in default_error_handler
    raise error
webkitpy.common.system.executive.ScriptError: Failed to run "['git',
'merge-base', 'refs/remotes/origin/master', 'HEAD']" exit_code: 1 cwd:
/data/develop/test-wk2/_other/webkit.master
  Running status to find changed, added, or removed files.
  No changes found.


$ Tools/Scripts/prepare-ChangeLog --nostyle -b
https://bugs.webkit.org/show_bug.cgi?id=205913
  Running status to find changed, added, or removed files.
  No changes found.

I also tried "git add Source/WebKit/UIProcess/gtk/KeyBindingTranslator.cpp",
but the prepare-ChangeLog didn't find the changes anyway.


More information about the webkit-reviews mailing list