[webkit-reviews] review granted: [Bug 171015] WebKit rejects changes between similar unprefixed & prefixed gradient syntax : [Attachment 386917] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 171015: WebKit rejects changes between similar unprefixed & prefixed
gradient syntax
https://bugs.webkit.org/show_bug.cgi?id=171015

Attachment 386917: Patch

https://bugs.webkit.org/attachment.cgi?id=386917&action=review




--- Comment #9 from Dean Jackson <dino at apple.com> ---
Comment on attachment 386917
  --> https://bugs.webkit.org/attachment.cgi?id=386917
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386917&action=review

> LayoutTests/fast/css/gradient-prefixed-unprefixed-toggle-expected.html:17
> +	   var UNPREFIXED_STYLE = "linear-gradient(to bottom, orange, blue)";
> +	   var PREFIXED_STYLE = "-webkit-linear-gradient(   bottom, orange,
blue)";

const!!! :)

Also, why the space before bottom?

> LayoutTests/fast/css/gradient-prefixed-unprefixed-toggle-expected.html:28
> +	       u.style.backgroundImage = UNPREFIXED_STYLE;
> +	       u2p.style.backgroundImage = PREFIXED_STYLE;
> +
> +	       p.style.backgroundImage = PREFIXED_STYLE;
> +	       p2u.style.backgroundImage = UNPREFIXED_STYLE;

Wow. That's old school element access there.