[webkit-reviews] review granted: [Bug 205807] REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure : [Attachment 386906] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 7 01:04:17 PST 2020


Dean Jackson <dino at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 205807: REGRESSION: [ Mac Debug ]
inspector/page/setBootstrapScript-main-frame.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205807

Attachment 386906: Patch

https://bugs.webkit.org/attachment.cgi?id=386906&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 386906
  --> https://bugs.webkit.org/attachment.cgi?id=386906
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386906&action=review

> Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:1432
> +	   let source = this._bootstrapScript.content || "";

Use ?? ? (wouldn't matter here though).

Also, this can be const.


More information about the webkit-reviews mailing list