[webkit-reviews] review granted: [Bug 208020] [First paint] Let optional style recalcs go through while in visually-non-empty state. : [Attachment 391318] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 208020: [First paint] Let optional style recalcs go through while in
visually-non-empty state.
https://bugs.webkit.org/show_bug.cgi?id=208020

Attachment 391318: Patch

https://bugs.webkit.org/attachment.cgi?id=391318&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 391318
  --> https://bugs.webkit.org/attachment.cgi?id=391318
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391318&action=review

> Source/WebCore/dom/Document.cpp:1875
>      auto shouldThrottleStyleRecalc = [&] {

Doesn't seem worth keeping this lambda now.

> Source/WebCore/dom/Document.cpp:3137
> +    if (view() && view()->isVisuallyNonEmpty())
>	   return false;

So this prevents the zero-delay layout timer from firing?

So need to get rid of that timer. Maybe this kills it for all
post-visually-empty states?