[webkit-reviews] review granted: [Bug 208021] [ews] Add build step to set cq- flag on bugzilla patch : [Attachment 391315] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 20 13:02:47 PST 2020
Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 208021: [ews] Add build step to set cq- flag on bugzilla patch
https://bugs.webkit.org/show_bug.cgi?id=208021
Attachment 391315: Patch
https://bugs.webkit.org/attachment.cgi?id=391315&action=review
--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 391315
--> https://bugs.webkit.org/attachment.cgi?id=391315
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=391315&action=review
> Tools/BuildSlaveSupport/ews-build/steps.py:452
> + flags = [{'name': 'commit-queue', 'status': '-'}]
Nit: Any reason to keep this on it's own line? It's only used on line 454, not
sure that it makes things more clear.
More information about the webkit-reviews
mailing list