[webkit-reviews] review granted: [Bug 207985] [WebAuthn] Replace DeviceIdentity.framework : [Attachment 391254] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 207985: [WebAuthn] Replace DeviceIdentity.framework
https://bugs.webkit.org/show_bug.cgi?id=207985

Attachment 391254: Patch

https://bugs.webkit.org/attachment.cgi?id=391254&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 391254
  --> https://bugs.webkit.org/attachment.cgi?id=391254
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391254&action=review

r=me

> Source/WebKit/ChangeLog:10
> +	   Invocations of the new framework is hidden in WKA. Please refer to
the radar for detailed information.

"The new experimental authentication logic is handled by WebKtAdditions. Please
refer to the radar for detailed information."

> Source/WebKit/ChangeLog:13
> +	   1) changes the way how user consent is obtained such that biometrics
will not be prompted twice.

changes how user consent is obtained to avoid multiple prompts for biometric
input.

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:174
>	   "allow " + creationOptions.rp.id + " to create a public key
credential for " + creationOptions.user.name,

Should this be "makeString("allow "_s, creationOptions.rp.id, " to create a
public key credential for"_s, creationOptions.user.name)