[webkit-reviews] review granted: [Bug 207963] Expose caret color for clients : [Attachment 391297] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 207963: Expose caret color for clients
https://bugs.webkit.org/show_bug.cgi?id=207963

Attachment 391297: Patch

https://bugs.webkit.org/attachment.cgi?id=391297&action=review




--- Comment #8 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 391297
  --> https://bugs.webkit.org/attachment.cgi?id=391297
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391297&action=review

> Source/WebKitLegacy/mac/WebView/WebFramePrivate.h:146
> +- (CGColorRef)getCaretColor;

This is ok as-is. The optimal solution would be to define @property caretColor
because:

1. Can remove -setCaretColor.
2. No need to add -getCaretColor
3. Because of (2) no need to rename -getCaretColor to -caretColor to conform to
WebKit Code Style guide.