[webkit-reviews] review granted: [Bug 207936] WebPageProxy::PolicyDecisionSender should send a struct instead of many parameters : [Attachment 391163] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 19 11:30:04 PST 2020


Alex Christensen <achristensen at apple.com> has granted
katherine_cheney at apple.com's request for review:
Bug 207936: WebPageProxy::PolicyDecisionSender should send a struct instead of
many parameters
https://bugs.webkit.org/show_bug.cgi?id=207936

Attachment 391163: Patch

https://bugs.webkit.org/attachment.cgi?id=391163&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 391163
  --> https://bugs.webkit.org/attachment.cgi?id=391163
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391163&action=review

> Source/WebKit/Shared/PolicyDecisionData.h:37
> +    uint64_t navigationID;

These should have default initializers so we don't accidentally use
uninitialized memory.
uint64_t navigationID { 0 };
etc.


More information about the webkit-reviews mailing list