[webkit-reviews] review granted: [Bug 151030] ASSERTION FAILED: roundedIntPoint(LayoutPoint(rendererMappedResult)) == result in WebCore::RenderGeometryMap::mapToContainer : [Attachment 391139] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jack
<shihchieh_lee at apple.com>'s request for review:
Bug 151030: ASSERTION FAILED:
roundedIntPoint(LayoutPoint(rendererMappedResult)) == result in
WebCore::RenderGeometryMap::mapToContainer
https://bugs.webkit.org/show_bug.cgi?id=151030

Attachment 391139: Patch

https://bugs.webkit.org/attachment.cgi?id=391139&action=review




--- Comment #21 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 391139
  --> https://bugs.webkit.org/attachment.cgi?id=391139
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391139&action=review

> Source/WebCore/platform/graphics/LayoutSize.h:139
> +#if ASSERT_ENABLED

No need to wrap this in #if ASSERT_ENABLED.  LayoutUnit::mightBeSaturated()
isn't.

> LayoutTests/fast/layers/geometry-map-saturated-offset-assert.html:10
> +	   -webkit-appearance:media-volume-slider-mute-button;
> +	   vertical-align:-53772756.9in;
> +	   overflow-y:hidden;
> +	   -webkit-padding-before:+.8mm;

Is this really the minimal test case? Can we do without 
media-volume-slider-mute-button and the -webkit prefixes?