[webkit-reviews] review granted: [Bug 207912] Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types : [Attachment 391097] Patch

[bugzilla-daemon at webkit.org]

Brian Weinstein <bweinstein at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 207912: Expand WKRemoteObjectCoder supported POD types to encode
NSURLResponse types
https://bugs.webkit.org/show_bug.cgi?id=207912

Attachment 391097: Patch

https://bugs.webkit.org/attachment.cgi?id=391097&action=review




--- Comment #2 from Brian Weinstein <bweinstein at apple.com> ---
Comment on attachment 391097
  --> https://bugs.webkit.org/attachment.cgi?id=391097
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391097&action=review

> Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:153
> +	   case 'S': {

Can these two cases be the same?

case ’s’:
case ’S’:
    …

> Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:366
> +    // char

Nit: // unsigned char..