[webkit-reviews] review denied: [Bug 151030] ASSERTION FAILED: roundedIntPoint(LayoutPoint(rendererMappedResult)) == result in WebCore::RenderGeometryMap::mapToContainer : [Attachment 391107] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jack
<shihchieh_lee at apple.com>'s request for review:
Bug 151030: ASSERTION FAILED:
roundedIntPoint(LayoutPoint(rendererMappedResult)) == result in
WebCore::RenderGeometryMap::mapToContainer
https://bugs.webkit.org/show_bug.cgi?id=151030

Attachment 391107: Patch

https://bugs.webkit.org/attachment.cgi?id=391107&action=review




--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 391107
  --> https://bugs.webkit.org/attachment.cgi?id=391107
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391107&action=review

> Source/WebCore/rendering/RenderGeometryMap.cpp:112
> +	   ASSERT(roundedIntPoint(LayoutPoint(rendererMappedResult)) == result
|| m_accumulatedOffsetSaturated);

I think this is a good place for ASSERT_IMPLIES:
ASSERT_IMPLIES(!m_accumulatedOffsetSaturated,
LayoutPoint(rendererMappedResult)) == result)

> Source/WebCore/rendering/RenderGeometryMap.cpp:272
> +	   if (m_accumulatedOffset.width().mightBeSaturated() ||
m_accumulatedOffset.height().mightBeSaturated())
> +	       m_accumulatedOffsetSaturated = true;

Why don't we add:
LayoutSize::mightBeSaturated() which returns true if width or height are
saturated, and change this to:
m_accumulatedOffsetSaturated |= m_accumulatedOffset.mightBeSaturated();