[webkit-reviews] review granted: [Bug 207903] NetworkDataTask should not expect its session wrapper to be always live : [Attachment 391079] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 18 14:07:45 PST 2020


Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 207903: NetworkDataTask should not expect its session wrapper to be always
live
https://bugs.webkit.org/show_bug.cgi?id=207903

Attachment 391079: Patch

https://bugs.webkit.org/attachment.cgi?id=391079&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 391079
  --> https://bugs.webkit.org/attachment.cgi?id=391079
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391079&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:321
>      if (!m_task || !m_session)

Let's just replace m_session with m_sessionWrapper, which is the only one used
in this function.


More information about the webkit-reviews mailing list