[webkit-reviews] review requested: [Bug 207903] NetworkDataTask should not expect its session wrapper to be always live : [Attachment 391079] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has asked  for review:
Bug 207903: NetworkDataTask should not expect its session wrapper to be always
live
https://bugs.webkit.org/show_bug.cgi?id=207903

Attachment 391079: Patch

https://bugs.webkit.org/attachment.cgi?id=391079&action=review




--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 391079
  --> https://bugs.webkit.org/attachment.cgi?id=391079
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391079&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h:93
> +    WeakPtr<SessionWrapper> m_sessionWrapper;

I think the WeakPtr is necessary in case of SessionWrapper being an isolated
session, which can be removed or cleared at various points in time.