[webkit-reviews] review denied: [Bug 207840] Web socket loads should be captured for logging per-page prevalent domains : [Attachment 390928] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 207840: Web socket loads should be captured for logging per-page prevalent
domains
https://bugs.webkit.org/show_bug.cgi?id=207840

Attachment 390928: Patch

https://bugs.webkit.org/attachment.cgi?id=390928&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 390928
  --> https://bugs.webkit.org/attachment.cgi?id=390928
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390928&action=review

>> Source/WebCore/Modules/websockets/WebSocket.cpp:314
>> +	   
frame->loader().client().addLoadedRegistrableDomain(RegistrableDomain(m_url));
> 
> This is a bit too soon.
> It might be better to add it after content blockers validation, which can
either block the load or change it.

Also, what about loads inside workers? This branch is only for documents.