[webkit-reviews] review granted: [Bug 207840] Web socket loads should be captured for logging per-page prevalent domains : [Attachment 390928] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 17 10:08:08 PST 2020


Dean Jackson <dino at apple.com> has granted katherine_cheney at apple.com's request
for review:
Bug 207840: Web socket loads should be captured for logging per-page prevalent
domains
https://bugs.webkit.org/show_bug.cgi?id=207840

Attachment 390928: Patch

https://bugs.webkit.org/attachment.cgi?id=390928&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 390928
  --> https://bugs.webkit.org/attachment.cgi?id=390928
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390928&action=review

>
LayoutTests/http/tests/websocket/web-socket-loads-captured-in-per-page-domains.
html:21
> +	       var passed = false;
> +	       for (var i = 0; i < arrayOfDomains.length; ++i) {
> +		   if (arrayOfDomains[i] === "localhost") {
> +		       passed = true;
> +		       break;
> +		   }
> +	       }
> +	       if (passed)

I think this can all be replaced with:

if (arrayOfDomains.includes("localhost"))
  testPassed....
else
..


More information about the webkit-reviews mailing list