[webkit-reviews] review granted: [Bug 220081] [CMake] Add USE_APPLE_ICU option : [Attachment 416707] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted monson
<holymonson at gmail.com>'s request for review:
Bug 220081: [CMake] Add USE_APPLE_ICU option
https://bugs.webkit.org/show_bug.cgi?id=220081

Attachment 416707: Patch

https://bugs.webkit.org/attachment.cgi?id=416707&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 416707
  --> https://bugs.webkit.org/attachment.cgi?id=416707
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416707&action=review

> Source/cmake/OptionsCommon.cmake:103
> +option(USE_APPLE_ICU "Use Apple's internal ICU" ${APPLE})

Should this be in OptionsMac.cmake  instead of here?