[webkit-reviews] review granted: [Bug 220106] Can't login to Skype from Microsoft Outlook account in Safari : [Attachment 416699] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 23 08:48:33 PST 2020
Alex Christensen <achristensen at apple.com> has granted
katherine_cheney at apple.com's request for review:
Bug 220106: Can't login to Skype from Microsoft Outlook account in Safari
https://bugs.webkit.org/show_bug.cgi?id=220106
Attachment 416699: Patch
https://bugs.webkit.org/attachment.cgi?id=416699&action=review
--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 416699
--> https://bugs.webkit.org/attachment.cgi?id=416699
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=416699&action=review
> Source/WebCore/page/Quirks.cpp:971
> +static bool isStorageAccessQuirkDomainElementPair(const URL& url, const
Element& element)
I'm not sure "Pair" is a good thing to have in this name.
> Source/WebCore/page/Quirks.cpp:1050
> + auto domainInNeedOfStorageAccess =
RegistrableDomain(*domainsInNeedOfStorageAccess.value().begin().get());
We should probably check if begin().get() is null, which could happen if
value() returns an empty container.
> Source/WebCore/platform/network/NetworkStorageSession.cpp:390
> +
map.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("live.com
"),
The HashMap& returned by this function should probably be const.
More information about the webkit-reviews
mailing list