[webkit-reviews] review granted: [Bug 219993] $(findstring iphone, $(SDKROOT)) fails when SDKROOT is not lowercase : [Attachment 416470] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryan Hostetler <rhost at apple.com>'s
request for review:
Bug 219993: $(findstring iphone,$(SDKROOT)) fails when SDKROOT is not lowercase
https://bugs.webkit.org/show_bug.cgi?id=219993

Attachment 416470: Patch

https://bugs.webkit.org/attachment.cgi?id=416470&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 416470
  --> https://bugs.webkit.org/attachment.cgi?id=416470
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416470&action=review

> Source/Makefile:6
> +	ifneq (,$(findstring macosx,$(notdir $(call to_lower,$(SDKROOT)))))

I think it would be better to call notdir first before calling shell, so we
pass a shorter string. Not sure why we used all lowercase for "to_lower" when
we use all uppercase for other make variables.