[webkit-reviews] review granted: [Bug 219972] SpeechRecognitionRemoteRealtimeMediaSourceManager should not issue sandbox extension for mocked devices : [Attachment 416426] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Sihui Liu
<sihui_liu at apple.com>'s request for review:
Bug 219972: SpeechRecognitionRemoteRealtimeMediaSourceManager should not issue
sandbox extension for mocked devices
https://bugs.webkit.org/show_bug.cgi?id=219972

Attachment 416426: Patch

https://bugs.webkit.org/attachment.cgi?id=416426&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 416426
  --> https://bugs.webkit.org/attachment.cgi?id=416426
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416426&action=review

> Source/WebCore/platform/mediastream/CaptureDevice.h:70
> +    bool mocked() const { return m_mocked; }
> +    void setMocked(bool mocked) { m_mocked = mocked; }

Nit: I think `mockDevice` or `isMockDevice` would be better than `mocked`

> Source/WebCore/platform/mediastream/CaptureDevice.h:133
> +    bool m_mocked { false };

Is there any reason to not add this to the encoder and decoder methods?

>
Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.h:76
> +    HashSet<WebCore::RealtimeMediaSourceIdentifier>
m_sourcesNeedSandboxExtension;

Nit: `m_sourcesNeedingSandboxExtension` might be a better name.

> Source/WebKit/UIProcess/SpeechRecognitionServer.h:85
> +    SpeechRecognitionCheckIfMockSpeechRecognitionEnabled
m_checkIfmockSpeechRecognitionEnabled;

s/m_checkIfmock/m_checkIfMock/